Skip to content

Conversation

@finger563
Copy link
Contributor

@finger563 finger563 commented Jun 23, 2025

Description

  • Update espp deps to latest (v1.0.11) to bring in WiFi CLI and bugfixes
  • Refactor main code to support CLI
  • Update readme
  • Update CI to build executables for both ESP-BOX and T-Deck

Motivation and Context

Allows users to more easily program / use / reconfigure without having to compile code.

How has this been tested?

Build and run main on esp-box.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2025-06-23 at 08 19 20

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@github-actions
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 requested a review from Copilot June 23, 2025 16:04
@finger563 finger563 self-assigned this Jun 23, 2025
@finger563 finger563 added bug Something isn't working enhancement New feature or request rtsp wifi cli command line interface labels Jun 23, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a WiFi configuration CLI for easier device programming and reconfiguration, along with various refactors to support improved RTSP client handling and build workflows. Key changes include updating ESP32 dependencies, refactoring main.cpp to integrate the CLI and related tasks, and modifying the CI workflow to build executables for both ESP-BOX and T-Deck targets.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdkconfig.defaults.{t-deck, esp32s3, esp-box} Added hardware-specific config definitions.
sdkconfig.defaults Enabled C++ exceptions for the CLI library.
main/main.cpp Refactored main logic to include CLI support, RTSP client/task handling, and display functions.
main/Kconfig.projbuild Updated WiFi credentials’ defaults.
README.md Expanded documentation with a table of contents and CLI usage instructions.
.github/workflows/package_main.yml Revised build matrix to support per-target build commands.
Comments suppressed due to low confidence (2)

main/main.cpp:51

  • The 'task_notified' parameter controls task termination in the callback, but its initialization or expected state isn’t clearly visible. Ensure that 'task_notified' is properly set before scheduling the RTSP client task to avoid unintended behavior.
bool start_rtsp_client(std::mutex &m, std::condition_variable &cv, bool &task_notified);

.github/workflows/package_main.yml:20

  • Matrix build entries no longer specify a 'command' field, which leads to an empty command in the build step. Consider adding the appropriate build command for each target (e.g. 'idf.py -DSDKCONFIG_DEFAULTS="sdkconfig.defaults;sdkconfig.esp-box" build').
        - name: 'esp-box'

@finger563 finger563 merged commit 03ca604 into main Jun 23, 2025
2 checks passed
@finger563 finger563 deleted the feat/wifi-cli branch June 23, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cli command line interface enhancement New feature or request rtsp wifi

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant