Skip to content

Conversation

@finger563
Copy link
Contributor

@finger563 finger563 commented Nov 14, 2023

Description

  • Separated out lcd configuration from lcd.cpp into box.hpp and added additional box_3.hpp and tdeck.hpp, which are included conditionally depending on new CONFIG_HARDWARE option which can be configured via menuconfig.

Motivation and Context

Adds support for other hardware and makes it easier to port to other hardware as well.

How has this been tested?

Building and running the new code on the ESP32-S3-BOX, ESP32-S3-BOX-3, and LilyGo T-Deck.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

…factoring support for Box). Select one of the three hardware configurations via menuconfig.
@finger563 finger563 added enhancement New feature or request esp32-s3-box esp32-s3-box-3 lilygo t-deck hal hardware abstraction layer labels Nov 14, 2023
@finger563 finger563 merged commit 93ea4f8 into main Nov 14, 2023
@finger563 finger563 deleted the feature/hardawre-support branch November 14, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request esp32-s3-box esp32-s3-box-3 hal hardware abstraction layer lilygo t-deck

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant