Skip to content
This repository was archived by the owner on Feb 26, 2022. It is now read-only.

Conversation

aykevl
Copy link

@aykevl aykevl commented Jul 16, 2020

I ran cargo run esp8266 to update this file and then formatted it with the VSCode XML extension. Unfortunately I couldn't get the lines to wrap, any help with that would be appreciated.

The change important to me is the <name> change from Espressif to esp8266, but it looks like there are a number of other changes as well (I don't know why). See MabezDev/idf2svd#17.

@icewind1991

@aykevl
Copy link
Author

aykevl commented Jul 20, 2020

I have updated the PR to remove formatting changes. There are a number of other changes, I'm not sure where they come from.

@MabezDev how do you wrap the lines? I tried Rewrap but it uses a different formatting.

@icewind1991
Copy link
Member

I'll try to do some basic testing with these changes and look into setting up some automated formatting for the xml instead of just going with "whatever my editor formats it as"

@jessebraham
Copy link
Member

jessebraham commented Jul 21, 2020

libxml2-utils provides a tool, xmllint, for formatting XML with various configuration options.

$ xmllint --format esp8266.base.svd

Python's xml.dom.minidom will format XML as well:

$ cat esp8266.base.svd | python -c '
import sys
import xml.dom.minidom
s = sys.stdin.read()
print(xml.dom.minidom.parseString(s).toprettyxml())
'

Those are two simple options, obviously many others exist.

@aykevl
Copy link
Author

aykevl commented Aug 5, 2020

@icewind1991 any update?
I can also make a PR like esp-rs/esp32#38 to make reviewing easier. I only really care about that change, the other changes are not relevant to me.

@icewind1991
Copy link
Member

Sorry for the delays,

the permission changes seem incorrect at least, I'll have a look at idf2svd to see why it changed

@icewind1991
Copy link
Member

See MabezDev/idf2svd#19

@aykevl
Copy link
Author

aykevl commented Aug 30, 2020

@icewind1991 thank you! Closing this PR as the relevant change is already included (with afc61d4).

@aykevl aykevl closed this Aug 30, 2020
@aykevl aykevl deleted the base-update branch August 30, 2020 22:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants