Skip to content

Partition table validation #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 1, 2021
Merged

Partition table validation #64

merged 7 commits into from
Oct 1, 2021

Conversation

icewind1991
Copy link
Member

Adds various validation steps and error messages for partition tables

  • Add error when partitions overlap
    Screenshot_20211001_140009
  • Add error when two partitions have the same name or sub-type
    Screenshot_20211001_141033
  • Add error when the type and sub-type don't match for a partition
    Screenshot_20211001_145719
    (the "trough" -> "through" typo has been fixed after taking the screenshot)
  • Better error message when an unknown sub-type is specified for a partition
    Screenshot_20211001_150801
  • Add error when app partitions aren't aligned properly
    Screenshot_20211001_152054

MabezDev
MabezDev approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Those error messages are beautifully clear!

jessebraham
jessebraham approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again, these new error messages are fantastic!

@icewind1991 icewind1991 merged commit 91e8ec6 into master Oct 1, 2021
@icewind1991 icewind1991 deleted the partition-table-validation branch October 1, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessebraham jessebraham jessebraham approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991 @jessebraham @MabezDev