Skip to content

Conversation

@d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Mar 6, 2018

also:
improve version string
remove useless message

also:
improve version string
remove useless message
@igrr
Copy link
Member

igrr commented Mar 7, 2018

So if ip == 0, we clear NETIF_FLAG_LINK_UP, is that right? I'm wondering whether we should still indicate that the link is up even if IP is not yet obtained...

@d-a-v
Copy link
Collaborator Author

d-a-v commented Mar 7, 2018

The thing is upstream lwip-1 does not give much importance to netif flag UP regarding dhcp client, so espressif implementation does not care: On the esp side, an interface is down if it does not have the LINK_UP flag and I think it does not care at all about UP.

Upstream lwip-2's dhcp client needs netif UP and the glue (lwip2) deals with that.

You are right, I was too violent. So without too many changes into lwip-2 side, LINK_UP is always set, and we play with the UP flag to know whether it i enabled or not. Espressif blobs are not aware of lwip-2 anyway.

@igrr
Copy link
Member

igrr commented Mar 7, 2018

Okay, the new diff makes sense to me. Is there something that needs to be tested here, or should i go ahead and merge once the CI passes?

@igrr igrr merged commit e47a92a into esp8266:master Mar 7, 2018
@d-a-v d-a-v deleted the lwip2 branch March 7, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants