Skip to content

Conversation

@Renegade605
Copy link
Contributor

Description:

  • Fix typos in sensor component ade7953.
  • Fix duplicated text in sensor component bl0942.

Related issue (if applicable): n/a

Pull request in esphome with YAML changes (if applicable): n/a

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /components/index.rst when creating new documents for new components or cookbook.

Apparent Power - missing a 'p' (aparent_power_x)
Volt Amperes - missing an 'e' (ampers)
Frequency - extra reference to other sensor options
@esphome esphome bot added the current label Nov 20, 2025
@netlify
Copy link

netlify bot commented Nov 20, 2025

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit c1d89f5
🔍 Latest deploy log https://app.netlify.com/projects/esphome/deploys/691f2ef948976500089c8305
😎 Deploy Preview https://deploy-preview-5655--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

Walkthrough

Documentation-only edits: fixed typos and renamed two ADE7953 configuration options from aparent_power_a/aparent_power_b to apparent_power_a/apparent_power_b with corrected unit wording, and removed a duplicated sentence in the BL0942 frequency section.

Changes

Cohort / File(s) Summary
ADE7953 sensor documentation fixes
content/components/sensor/ade7953.md
Renamed aparent_power_aapparent_power_a and aparent_power_bapparent_power_b in docs; corrected unit phrasing from "volt ampers" to "volt amperes"; fixed "rective" → "reactive" typos.
BL0942 sensor documentation cleanup
content/components/sensor/bl0942.md
Removed duplicate sentence "All options from Sensor." under frequency configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Documentation-only, small localized text changes.
  • Areas to spot-check:
    • content/components/sensor/ade7953.md — verify all occurrences of the renamed keys and unit text were updated consistently.
    • content/components/sensor/bl0942.md — confirm duplicate sentence removal didn’t affect adjacent formatting or links.

Suggested reviewers

  • jesserockz
  • nagyrobi

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: fixing typos and removing duplicated text in sensor documentation files.
Description check ✅ Passed The description clearly relates to the changeset by specifying the typo fixes in ade7953 and duplicated text removal in bl0942.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8397a6c and c1d89f5.

📒 Files selected for processing (1)
  • content/components/sensor/ade7953.md (4 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

  • Do not generate or add any sequence diagrams

Files:

  • content/components/sensor/ade7953.md
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: esphome/esphome-docs PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-24T00:13:13.459Z
Learning: Open pull requests against the correct base branch: use `current` for documentation-only revisions and `next` for changes tied to new features in esphome/esphome
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build
🔇 Additional comments (1)
content/components/sensor/ade7953.md (1)

85-101: All previously flagged typo issues have been successfully fixed.

The changes address all the issues identified in past review comments:

  • "rective" → "reactive" corrections are applied consistently across all reactive power descriptions (lines 97, 100 in I²C section; lines 205, 208 in SPI section).
  • Unit phrasing is now consistent using "volt amperes" for both apparent and reactive power options.
  • Configuration option names use correct spelling throughout.

Note: This PR also mentions fixing duplicated text in content/components/sensor/bl0942.md, but that file was not provided for review. Please ensure those changes are similarly verified.

Also applies to: 193-209

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5411221 and 8397a6c.

📒 Files selected for processing (2)
  • content/components/sensor/ade7953.md (4 hunks)
  • content/components/sensor/bl0942.md (0 hunks)
💤 Files with no reviewable changes (1)
  • content/components/sensor/bl0942.md
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

  • Do not generate or add any sequence diagrams

Files:

  • content/components/sensor/ade7953.md
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: esphome/esphome-docs PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-24T00:13:13.459Z
Learning: Open pull requests against the correct base branch: use `current` for documentation-only revisions and `next` for changes tied to new features in esphome/esphome
🪛 LanguageTool
content/components/sensor/ade7953.md

[grammar] ~97-~97: Ensure spelling is correct
Context: ...eactive_power_a** (Optional): Use the rective power value of the A channel in volt am...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)


[grammar] ~100-~100: Ensure spelling is correct
Context: ...eactive_power_b** (Optional): Use the rective power value of the B channel in volt am...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)


[grammar] ~205-~205: Ensure spelling is correct
Context: ...eactive_power_a** (Optional): Use the rective power value of the A channel in volt am...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)


[grammar] ~208-~208: Ensure spelling is correct
Context: ...eactive_power_b** (Optional): Use the rective power value of the B channel in volt am...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build
🔇 Additional comments (2)
content/components/sensor/ade7953.md (2)

85-88: Correct typo fix for apparent power configuration options.

The renaming from aparent_power_a/b to apparent_power_a/b is correct, and the unit phrasing "volt amperes" is accurate.


193-196: Correct typo fix for apparent power in SPI section.

The renaming and unit phrasing for apparent_power_a/b are consistent with the I²C section and correctly updated.

It catches a second typo lol.
@clydebarrow clydebarrow merged commit 680f955 into esphome:current Nov 20, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants