fix: silence multiple warnings pointed in issue #11917 #11920
Conversation
|
|
👋 Hello cziter15, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
cziter15
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| static volatile TaskHandle_t _udp_task_handle = NULL; | ||
|
|
||
| static void _udp_task(void *pvParameters) { | ||
| (void)pvParameters; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
|
|
||
| bool PBKDF2_HMACBuilder::addStream(Stream &stream, const size_t maxLen) { | ||
| log_e("PBKDF2_HMACBuilder does not support addStream. Use setPassword() and setSalt() instead."); | ||
| (void)stream; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
| bool PBKDF2_HMACBuilder::addStream(Stream &stream, const size_t maxLen) { | ||
| log_e("PBKDF2_HMACBuilder does not support addStream. Use setPassword() and setSalt() instead."); | ||
| (void)stream; | ||
| (void)maxLen; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
| } | ||
|
|
||
| bool UpdateClass::begin(size_t size, int command, int ledPin, uint8_t ledOn, const char *label) { | ||
| (void)label; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
|
|
||
| bool WebServer::authenticate(const char *_username, const char *_password) { | ||
| return WebServer::authenticate([_username, _password](HTTPAuthMethod mode, String username, String params[]) -> String * { | ||
| (void)mode; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
| bool WebServer::authenticate(const char *_username, const char *_password) { | ||
| return WebServer::authenticate([_username, _password](HTTPAuthMethod mode, String username, String params[]) -> String * { | ||
| (void)mode; | ||
| (void)params; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
| } | ||
|
|
||
| bool canRaw(const String &requestUri) override { | ||
| (void)requestUri; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
| } | ||
|
|
||
| bool canRaw(WebServer &server, const String &requestUri) override { | ||
| (void)requestUri; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
| virtual ~Middleware() {} | ||
|
|
||
| virtual bool run(WebServer &server, Callback next) { | ||
| (void)server; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
Removed deprecated flush() comment and updated code.
|
@me-no-dev Not sure about that |
Test Results 76 files 76 suites 14m 29s ⏱️ Results for commit 42b0e01. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||
|
|
||
| _chunkedClient.flush(); | ||
| _chunkedClient.clear(); |
There was a problem hiding this comment.
This is a breaking change. Please revert.
There was a problem hiding this comment.
It's what warning suggested. Actually i'm on mobile, so limited ability to go through client classes. Why is it breaking?
There was a problem hiding this comment.
makes no sense when beeing on mobile. Look through the PRs made regarding flush <-> clear
There was a problem hiding this comment.
There was a problem hiding this comment.
It seems that the documentation isn’t accurate.
flush() is calling clear() at:
but only in WifiClientSecure.cpp is actually doing nothing:
so yes @Jason2866 it's better not touch this, but that depecation is misleading
4 participants
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
Resolve warnings as described in #11917
Related links
Closes #11917