Skip to content

fix(net): Rework NO_GLOBALS to not act on dependent network classes #11933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
+4 −6
Merged

fix(net): Rework NO_GLOBALS to not act on dependent network classes #11933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions libraries/ESPmDNS/src/ESPmDNS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,7 @@ class MDNSResponder {
mdns_txt_item_t *_getResultTxt(int idx, int txtIdx);
};

#if !defined(NO_GLOBAL_INSTANCES) && !defined(NO_GLOBAL_MDNS)
extern MDNSResponder MDNS;
#endif

#endif /* CONFIG_MDNS_MAX_INTERFACES */
#endif //ESP32MDNS_H
2 changes: 2 additions & 0 deletions libraries/Ethernet/src/ETH.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1174,6 +1174,8 @@ size_t ETHClass::printDriverInfo(Print &out) const {
return bytes;
}

#if !defined(NO_GLOBAL_INSTANCES) && !defined(NO_GLOBAL_ETH)
ETHClass ETH;
#endif

#endif /* CONFIG_ETH_ENABLED */
2 changes: 0 additions & 2 deletions libraries/Network/src/NetworkManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,4 @@ class NetworkManager : public NetworkEvents, public Printable {
}
};

#if !defined(NO_GLOBAL_INSTANCES) && !defined(NO_GLOBAL_NETWORK)
extern NetworkManager Network;
#endif
2 changes: 2 additions & 0 deletions libraries/PPP/src/PPP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,8 @@ size_t PPPClass::printDriverInfo(Print &out) const {
return bytes;
}

#if !defined(NO_GLOBAL_INSTANCES) && !defined(NO_GLOBAL_PPP)
PPPClass PPP;
#endif

#endif /* CONFIG_LWIP_PPP_SUPPORT */
2 changes: 0 additions & 2 deletions libraries/WiFi/src/WiFi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ class WiFiClass : public WiFiGenericClass, public WiFiSTAClass, public WiFiScanC
bool isProvEnabled();
};

#if !defined(NO_GLOBAL_INSTANCES) && !defined(NO_GLOBAL_WIFI)
extern WiFiClass WiFi;
#endif

#endif /* SOC_WIFI_SUPPORTED */
Loading