Skip to content

Conversation

@me-no-dev
Copy link
Member

@me-no-dev me-no-dev commented Nov 17, 2025

This pull request introduces support for selecting and building against different ESP32P4 chip variants, improving flexibility for board configuration and toolchain compatibility. The changes primarily add a new "Chip Variant" menu option, update build variables to use the selected chip variant, and ensure the correct SDK paths are used during compilation.

Board configuration enhancements:

  • Added a new Chip Variant menu option in boards.txt to allow users to select between different chip variants for ESP32P4 boards.
  • Defined specific chip variant options (prev3 and postv3) for ESP32P4, with corresponding build flags and CPU frequencies.

Build system updates:

  • Introduced the esp32p4.build.chip_variant variable in boards.txt for more precise board configuration.
  • Updated platform.txt to use {build.chip_variant} instead of {build.mcu} for SDK paths, ensuring the correct libraries are used for each variant.
  • Added build.chip_variant={build.mcu} to platform.txt to propagate the chip variant setting through the build process.

Depends on espressif/esp32-arduino-lib-builder#333

@me-no-dev me-no-dev added Status: Review needed Issue or PR is awaiting review Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first labels Nov 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "add Chip variant to pioarduino-build.py (#12037)":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello me-no-dev, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5ddff74

* add `chip_variant` to pioarduino-build.py

to support different variants of an MCU (p4 prev3 and postv3)

* Refactor build_mcu and chip_variant assignment logic

* ci(pre-commit): Apply automatic fixes

* Fix chip_variant retrieval with default value

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@me-no-dev
Copy link
Member Author

@P-R-O-C-H-Y also removed the CPU freq selection menu, because it makes no sense anymore

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first Status: Review needed Issue or PR is awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants