-
Notifications
You must be signed in to change notification settings - Fork 1
feat: lazy loading for constants and soc_header in bool_parser (RDT-1071) #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||
hfudev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
|
||
| if self.attr == 'CONFIG_NAME': | ||
| return config_name | ||
| from .soc_header import SOC_HEADERS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we prioritize loading the environment variables? so if I rely on one env var defined locally, there's no need to check and load the IDF_PATH (which may not exist)
The original comment:
for non-keyword cap words, check if it is defined in the environment variables
no idea why I put it here... I can't think of a real risk about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall the sequence could be
- additional_attr
- IDF_TARGET
- CONFIG_NAME
- env var
- IDF_VERSION(_XXX) - lazy-load
- SOC_CAPS - lazy-load
|
after this got merged, shall we release 0.1.0 and add this dependency in idf-build-apps and pytest-embedded? |
Sure, let's do it. I will start with pytest-embedded. |
Description
Reorganized the
constantsandsoc_headerimports inbool_parser, moving them closer to their usage.Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: