fix(esp_hosted_ng): Remove specific compilation SDIO left-overs #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With commit b544b01 something has been left behind: * Documentation of ESP_SLAVE_CHIPSET * ESP_SLAVE variable both don't exist anymore. So drop comments and script usage Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
giuliobenetti
added a commit
to Benetti-Engineering/buildroot
that referenced
this pull request
Oct 3, 2025
As pointed in this PR[0] ESP_SLAVE and CONFIG_TARGET_* became useless after commit [1] so let's drop the SoC Target choice. The SoC ID is automatically retrieved via SDIO commands, so no need to specify it. [0]: espressif/esp-hosted#668 [1]: espressif/esp-hosted@b544b01 Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Collaborator
|
@Shreyas0-7 can you please add this commit from @giuliobenetti ? |
Contributor
|
@giuliobenetti thanks for your contribution |
giuliobenetti
added a commit
to Benetti-Engineering/buildroot
that referenced
this pull request
Oct 7, 2025
As pointed in this PR[0] ESP_SLAVE and CONFIG_TARGET_* became useless after commit [1] so let's drop the SoC Target choice. The SoC ID is automatically retrieved via SDIO commands, so no need to specify it. [0]: espressif/esp-hosted#668 [1]: espressif/esp-hosted@b544b01 Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Collaborator
|
merged commit c8523c7 |
Collaborator
|
Thank you @giuliobenetti for all the efforts and time.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With commit b544b01 something has been left behind: