Skip to content

Conversation

@gabsuren
Copy link
Collaborator

@gabsuren gabsuren commented Nov 6, 2025

Remove dead code from WEBSOCKET_STATE_CONNECTED case that checked
read_select == 0. This condition is already properly handled by the
poll/receive logic outside the switch statement.


Note

Removes a redundant read_select == 0 check in WEBSOCKET_STATE_CONNECTED and centralizes read poll timeout logging in the post-poll branch.

  • WebSocket client (components/esp_websocket_client/esp_websocket_client.c):
    • Remove redundant read_select == 0 handling inside WEBSOCKET_STATE_CONNECTED.
    • Add unified else-branch after esp_transport_poll_read() to log read poll timeouts (ESP_LOGV).

Written by Cursor Bugbot for commit 1e83bee. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gabsuren gabsuren requested a review from david-cermak November 6, 2025 09:33
@gabsuren gabsuren self-assigned this Nov 6, 2025
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an optional suggestion

@gabsuren gabsuren force-pushed the refactor/websocket_timeout_check_remove branch from 069ddc1 to 1e83bee Compare November 12, 2025 18:01
@gabsuren
Copy link
Collaborator Author

LGTM, just an optional suggestion

Thank you for the review! Could you please approve it if it is ok for yoy?

Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabsuren gabsuren merged commit 4d7c684 into espressif:master Nov 13, 2025
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants