Add general support for CH347 based interfaces and configurations for EasyDevKits interfaces (OCD-839) #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
device description, activity LED added jtag_libusb_open enhanced for checking the device description
The LED output can alsob e acrive low
https://github.com/coflery/openocd - Constants for usb timeouts added - Read the firmware version on open - ch347_reset: do nothing if trst/srst are unset (seen in ftdi driver) - CH347_MoveState: Don't skip the move to TAP_RESET
- Added CH347_WriteReadBitwise -read/write for older chip versions - Added CH347_ScanDataToFields and fixed a bug for fields without data - for scan fields without data (one bit field) for skipping targets the bits need also be counted
* esp/ci: Makes OpenOCD tool name in lower case in IDF branch name * esp/ci: update openocd-ci-env and remove install packages --------- Co-authored-by: Alexey Gerenkov <alexey@espressif.com> Co-authored-by: Erhan Kurubas <erhan.kurubas@espressif.com>
…t64_t to make the windows compiler happy.
Misspelling in function name fixed
github-actions
bot
changed the title
Collaborator
|
@EasyDevKits Thank you for creating the PR and putting in the hard work to make this driver compatible with our chips. Since the PR is not directly related to our chips, unfortunately, this isn't the right approach to merge it into our fork. Please consider creating a patch for the official mainline first. No worries, we will be cherry-picking that commit once it is merged. |
Collaborator
|
And I suggest to divide the patches into 2 parts. |
espressif-bot
added
Status: Done
Resolution: Won't Do
and removed
Status: Opened
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found that in the openocd-esp32 repositiory is no support for CH347 based JTAG adapters. A WCH CH347 chip in mode 3 has one UART and one JTAG interface. Like an FTDI FT2232 chip, you can use the CH347 chip for UART and JTAG. With this change I add support for CH347 based JTAG adapters. I also add configuration files for the upcoming EasyDevKits JTAG adapters.
Maybe a documentation update is needed to state that now also CH347 based adapters are supported.
Type of change
User Impact
Now you can JTAG debug ESP32 chips with CH347 base JTAG adapters.
Performance Impact
I changed the timeout in esp_xtensa_reset_reason_read in file src/target/espressif/esp_xtensa.c from 100ms to 200ms because it was not working for the CH347 with 100ms timeout. Other parts are unchanged. Only the new driver added.
How Has This Been Tested?
Hardware Configuration:
Software Configuration:
Checklist: