Skip to content

Conversation

@hfudev
Copy link
Member

@hfudev hfudev commented Aug 22, 2025

closes #366

@hfudev hfudev requested a review from Copilot August 22, 2025 08:53
@hfudev hfudev self-assigned this Aug 22, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the qemu_prog_path property in the QemuApp class by converting it from a property to an instance attribute that can be set during initialization. This allows users to specify a custom QEMU program path when creating a QemuApp instance.

  • Converts qemu_prog_path from a computed property to a configurable instance attribute
  • Adds a new optional parameter qemu_prog_path to the __init__ method
  • Sets the attribute during initialization with fallback to the default format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hfudev hfudev marked this pull request as ready for review August 22, 2025 08:54
@hfudev hfudev force-pushed the fix/qemu-app-extra-args branch from 682aa5c to 05af5bc Compare September 8, 2025 12:09
@hfudev hfudev merged commit 0e40709 into main Sep 8, 2025
3 of 5 checks passed
@hfudev hfudev deleted the fix/qemu-app-extra-args branch September 8, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsupported --qemu-prog-path option (RDT-1450)

2 participants