Skip to content

Conversation

@Lapshin
Copy link
Contributor

@Lapshin Lapshin commented Aug 27, 2025

Description

Rename prefix_map_gdbinit to gdbinit/prefix_map

Related

  • IDF MR !41549
  • IDF-11667

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@github-actions github-actions bot changed the title change: rename prefix_map_gdbinit to gdbinit/prefix_map change: rename prefix_map_gdbinit to gdbinit/prefix_map (RDT-1461) Aug 27, 2025
@Lapshin
Copy link
Contributor Author

Lapshin commented Aug 27, 2025

If master branch of pytest-embedded is used for testing ESP-IDF master branch only, that will be ok.

But if it is used for testing old IDF (v5.4 or below), additional logic should be added to find the file

@igrr
Copy link
Member

igrr commented Aug 27, 2025

Seems like we can get it from project_description.json, would that help? It exists in all supported IDF branches.
https://github.com/espressif/esp-idf/blob/47a659cd3ee5f73a253d2a7af02781a73a44356d/tools/cmake/project_description.json.in#L32

@Lapshin
Copy link
Contributor Author

Lapshin commented Aug 27, 2025

@igrr , it's IDF v6.0 breaking change to remove this outdated JSON field / gdbinit file.

In favor of

    "gdbinit_files": {
        "01_symbols": "${gdbinit_files_symbols}",
        "02_prefix_map": "${gdbinit_files_prefix_map}",
        "03_py_extensions": "${gdbinit_files_py_extensions}",
        "04_connect": "${gdbinit_files_connect}"
    },

and gdbinit/prefix_map

@dobairoland
Copy link

@hfudev PTAL

@hfudev
Copy link
Member

hfudev commented Sep 1, 2025

Hi @Lapshin would it be a breaking change for earlier versions of esp-idf? pytest-embedded still supports all 5.x esp-idf branches.

if it's not a breaking change, then it LGTM.

@Lapshin Lapshin force-pushed the feature/gdbinit-files-generation-update branch from 3de0a94 to 0d28447 Compare September 2, 2025 13:01
@Lapshin
Copy link
Contributor Author

Lapshin commented Sep 2, 2025

@hfudev , now it should be backward compatible. Please check

Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Lapshin Lapshin force-pushed the feature/gdbinit-files-generation-update branch from 0d28447 to 5301a94 Compare September 2, 2025 15:08
@hfudev
Copy link
Member

hfudev commented Sep 3, 2025

Thank you. LGTM.

@hfudev hfudev merged commit 7e66a07 into espressif:main Sep 3, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants