-
Notifications
You must be signed in to change notification settings - Fork 36
change: rename prefix_map_gdbinit to gdbinit/prefix_map (RDT-1461) #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: rename prefix_map_gdbinit to gdbinit/prefix_map (RDT-1461) #368
Conversation
|
If master branch of But if it is used for testing old IDF (v5.4 or below), additional logic should be added to find the file |
|
Seems like we can get it from project_description.json, would that help? It exists in all supported IDF branches. |
|
@igrr , it's IDF v6.0 breaking change to remove this outdated JSON field / gdbinit file. In favor of and gdbinit/prefix_map |
|
@hfudev PTAL |
|
Hi @Lapshin would it be a breaking change for earlier versions of esp-idf? if it's not a breaking change, then it LGTM. |
3de0a94 to
0d28447
Compare
|
@hfudev , now it should be backward compatible. Please check |
hfudev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
0d28447 to
5301a94
Compare
|
Thank you. LGTM. |
Description
Rename
prefix_map_gdbinittogdbinit/prefix_mapRelated
Testing
Checklist
Before submitting a Pull Request, please ensure the following: