fix(video): fix uninitialized value #25
Merged
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijunru-hub
force-pushed
the
fix/video_uninitialized_value
branch
2 times, most recently
from
2c547d8 to
6fbc52c
Compare
lijunru-hub
force-pushed
the
fix/video_uninitialized_value
branch
from
6fbc52c to
c92ceeb
Compare
roma-jam
approved these changes
Apr 30, 2024
Collaborator
roma-jam
left a comment
roma-jam
left a comment
There was a problem hiding this comment.
We can wait a bit (till the moment you done with the code) and release the new version after that.
Meanwhile, these changes LGTM.
lijunru-hub
force-pushed
the
fix/video_uninitialized_value
branch
2 times, most recently
from
901702e to
dc92184
Compare
lijunru-hub
changed the title
lijunru-hub
force-pushed
the
fix/video_uninitialized_value
branch
2 times, most recently
from
f31080d to
669c4e4
Compare
lijunru-hub
force-pushed
the
fix/video_uninitialized_value
branch
from
669c4e4 to
ff7f67d
Compare
Author
|
@peter-marcisovsky PTAL |
roma-jam
changed the title
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Resolve a compilation error (uninitialized variable).
Resolve close endpoint error (error assert)