- 
                Notifications
    You must be signed in to change notification settings 
- Fork 38
Prepare release/v0.19 branch #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0c3af3a    to
    ca980f1      
    Compare
  
    a65df24    to
    debf359      
    Compare
  
    018fcf8    to
    36dff04      
    Compare
  
    | export EXTRA_CXXFLAGS="${PEDANTIC_FLAGS}" | ||
| python .github/ci/override_managed_component.py tinyusb . ${{ env.ESP_TINYUSB_TEST_APPS }}/*/ | ||
| idf-build-apps find --path ${{ env.ESP_TINYUSB_TEST_APPS }}/ --recursive --target esp32s2 --manifest-file ${{ env.ESP_USB_MANIFEST }} | ||
| idf-build-apps build --path ${{ env.ESP_TINYUSB_TEST_APPS }}/ --recursive --target esp32s2 --manifest-file ${{ env.ESP_USB_MANIFEST }} | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build only for esp32s2 ? Since you are using build-test-rules.yml from esp-usb you can set --target all and the SOC_CAPS will sort the targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we also have the network example in the build step, apply --target all is relevant only for usb_test_apps.
Enabling the same in the esp_idf_examples will lead to build the sta2eth example for all supported targets, not only the one relevant for us.
UPD:
part of the log from the last run (duration of the step ~6 minutes):
(cmake) App /opt/esp/idf/examples/network/sta2eth/, target esp32, sdkconfig (default), build in /opt/esp/idf/examples/network/sta2eth/build
45
(cmake) App /opt/esp/idf/examples/network/sta2eth/, target esp32c2, sdkconfig (default), build in /opt/esp/idf/examples/network/sta2eth/build
46
(cmake) App /opt/esp/idf/examples/network/sta2eth/, target esp32c3, sdkconfig (default), build in /opt/esp/idf/examples/network/sta2eth/build
47
(cmake) App /opt/esp/idf/examples/network/sta2eth/, target esp32c6, sdkconfig (default), build in /opt/esp/idf/examples/network/sta2eth/build
48
(cmake) App /opt/esp/idf/examples/network/sta2eth/, target esp32s2, sdkconfig (default), build in /opt/esp/idf/examples/network/sta2eth/build
49
(cmake) App /opt/esp/idf/examples/network/sta2eth/, target esp32s3, sdkconfig (default), build in /opt/esp/idf/examples/network/sta2eth/build
b669329    to
    d350b1e      
    Compare
  
    61be9a2    to
    fc59411      
    Compare
  
    fc59411    to
    d2cdc3d      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to
- remove esp_tinyusb test-apps run because it is very difficult to maintain.
- comment out preview builds, as they are not stable (currently not passing with esp-idf:latest docker, but passing locally)
ToDo
Changes compared to release/v0.18
idf-build-appsin GH workflowsupload-components-ci-actionto v2idf_component.ymlidf_component.ymltusb_teardown()now renamed totusb_deinit()Closes espressif/esp-usb#280