Upstream Synchronization - Partial [v0.19] #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
~~Closed due to the release of the version 0.20.0. ~~ Re-opened with solution:
|
This was referenced Nov 20, 2025
dwc2 requires manually toggle Even/Odd bit manually for ISO IN transfer, that's poses a problem when bInterval > 1 mainly for audio class, as the moment the transfer is scheduled, we don't know when the host will issue IN token (bInterval vs bRefresh schenanigans). Linux driver use NAK interrupt to detect when the host is sending IN token and toggle the Even/Odd bit accordingly based on the current frame number and bInterval. However on ST's stripped down DWC2 FS controller (e.g STM32F4, STM32F7), NAK interrupt is not supported, even it's marked as always present in DWC2 databook. NAK interrupt is only supported on HS controller with external PHY. Instead I schedule all ISO IN transfer for next frame, if the transfer failed, incomplete isochronous IN transfer interrupt will be triggered and we can relaunch the transfer. This is a combination of 4 commits, including: - dwc2: support ISO IN transfer when bInterval > 1 - Retry until bInterval - Simply restart the transfer - extract to handle_incomplete_iso_in() for readability Signed-off-by: HiFiPhile <admin@hifiphile.com>
This is a combination of 3 commits: - Fix preset with espressif - dcd/dwc2: fix enumration when EP0 size=8 - dcd/dwc2: cleanup previous pending EP0 IN transfer if a SETUP packet is received Signed-off-by: Mengsk <admin@hifiphile.com>
roma-jam
force-pushed
the
sync/partial_upstream
branch
from
5bf9942 to
9851796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contain cherry-picked changes from the upstream to solve the limitations in #68
Goal
2 instead of the previous releases: v0.19.01v0.20.0~1from here: Upstream synchronization [v0.20] #70Changes
Fix EP0 multi-packet transfer logic (potential 3295)moved to thev0.20.0~1releaseRelates
Verification
ESP-IDF USB Examples Run isn't available in CI. Verified manually.