Skip to content

Conversation

@milnowak
Copy link
Contributor

We've told the infra team they can remove the Jenkins instance but I saw a job ran for this project today.
Are there still any Jenkins dependencies here?

@milnowak milnowak requested a review from jkotan April 29, 2025 07:52
@milnowak milnowak changed the title Issue 667: decomissioning Jenkins server (#667) Issue 667: decomissioning Jenkins server Apr 29, 2025
@jkotan
Copy link
Collaborator

jkotan commented Apr 29, 2025

Hi @milnowak, yes sure. Could you please change

diff --git a/.github/workflows/cmake-build.yml b/.github/workflows/cmake-build.yml
index cb0df69c..c3499ec3 100644
--- a/.github/workflows/cmake-build.yml
+++ b/.github/workflows/cmake-build.yml
@@ -32,7 +32,7 @@ jobs:
     #   image: ${{ matrix.image }}
     #   options: '--user=root'
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Set environment variables
         run: |
             bash .github/workflows/set_env_vars.sh \
@@ -58,7 +58,7 @@ jobs:
           conan lock create conanfile.py ${CONAN_ARGS} --lockfile-packages --lockfile-out base.lock
           conan lock create conanfile.py ${CONAN_ARGS} --build missing
       - name: cache conan dependencies
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/.conan/data
           key: conan-${{ matrix.profile }}-${{ hashfiles('base.lock') }}-${{ hashFiles('conan.lock') }}
@@ -105,7 +105,7 @@ jobs:
         ]
     runs-on: windows-2022
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Add MSVC to PATH
         uses: ilammy/msvc-dev-cmd@v1
       - name: Set environment variables
@@ -126,7 +126,7 @@ jobs:
           conan lock create conanfile.py ${CONAN_ARGS} --lockfile-packages --lockfile-out base.lock
           conan lock create conanfile.py ${CONAN_ARGS} --build missing
       - name: cache conan dependencies
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/.conan/data
           key: conan-vs2022-${{ hashfiles('base.lock') }}-${{ hashFiles('conan.lock') }}
@@ -173,8 +173,8 @@ jobs:
         ]
     runs-on: macos-13
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-python@v2
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v4
         with:
           python-version: '3.x'
       - name: Set environment variables
@@ -206,7 +206,7 @@ jobs:
           conan lock create conanfile.py ${CONAN_ARGS} --lockfile-packages --lockfile-out base.lock
           conan lock create conanfile.py ${CONAN_ARGS} --build missing
       - name: cache conan dependencies
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/.conan/data
           key: conan-apple-clang12-${{ hashfiles('base.lock') }}-${{ hashFiles('conan.lock') }}
@@ -258,11 +258,11 @@ jobs:
           mpi,
           serial
         ]
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     container:
       image: debian:bookworm
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Set environment variables
         run: |
           bash .github/workflows/set_env_vars.sh \

to make test passed on github

@jkotan
Copy link
Collaborator

jkotan commented Apr 29, 2025

@milnowak , shall we add docs generator mentioned in #667 in a separate PR or do it in the current ?

@milnowak
Copy link
Contributor Author

Hi Jan, thanks for your quick response. I'll try to implement a github workflow for generating docs in this PR

@jkotan jkotan self-requested a review April 29, 2025 09:48
@jkotan
Copy link
Collaborator

jkotan commented Apr 29, 2025

Hi Jan, thanks for your quick response. I'll try to implement a github workflow for generating docs in this PR

Great. A similar generator I have added at https://github.com/lavue-org/lavue/blob/06bc4af62dc05098340c1b2b22dff5980e1d2165/.github/workflows/tests.yml#L74 If you need some help let me know.

@milnowak milnowak marked this pull request as draft April 29, 2025 11:23
@milnowak milnowak force-pushed the issue_667 branch 3 times, most recently from 7345097 to 45872e6 Compare April 29, 2025 12:52
@jkotan jkotan mentioned this pull request May 2, 2025
@milnowak
Copy link
Contributor Author

milnowak commented May 2, 2025

Hi @jkotan,

I wasn’t able to get the automated documentation deployment working, and unfortunately, I can’t spend more time on it at the moment. I hope to revisit it in the future.

For now, I’ve added a note in the README explaining that the documentation needs to be updated and deployed manually. I didn’t want this to block the release.

Best,
Miłosz

@milnowak milnowak marked this pull request as ready for review May 2, 2025 12:32
Copy link
Collaborator

@jkotan jkotan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotan jkotan merged commit dec0bb4 into master May 2, 2025
56 checks passed
@jkotan jkotan deleted the issue_667 branch May 2, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants