Skip to content

Finalise Waldur workflow docs for MLP #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2025
Merged

Finalise Waldur workflow docs for MLP #117

merged 4 commits into from
May 23, 2025

Conversation

@bcumming
Copy link
Member

@bcumming bcumming commented May 22, 2025 •
edited
Loading

@bcumming bcumming requested review from RMeli and msimberg as code owners May 22, 2025 09:01
@github-actions
Copy link

github-actions bot commented May 22, 2025

preview available: https://docs.tds.cscs.ch/117

@bcumming
Copy link
Member Author

bcumming commented May 22, 2025

These changes are a cut and paste of existing docs with small tweaks.
https://confluence.cscs.ch/spaces/KB/pages/865635993/1.+Onboarding+users+to+projects+using+CSCS+new+portal
https://confluence.cscs.ch/spaces/KB/pages/865637137/2.+Register+for+a+CSCS+account

I removed some images that were not needed (in my opinion), and linked to the existing docs on how to set up MFA.

msimberg
msimberg requested changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this whole section could do with a proper review. I pointed out a few minor style things, but not insisting on those changes if this needs to be revisited anyway.

The few typos would be nice to have fixed already now.

bcumming and others added 3 commits May 22, 2025 12:47
@bcumming @msimberg
Update docs/accounts/account-create.md
2d90d9d 
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bcumming @msimberg
Update docs/accounts/account-create.md
8539202 
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bcumming @msimberg
Update docs/accounts/waldur.md
6062871 
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@github-actions
Copy link

github-actions bot commented May 22, 2025

preview available: https://docs.tds.cscs.ch/117

2 similar comments
@github-actions
Copy link

github-actions bot commented May 22, 2025

preview available: https://docs.tds.cscs.ch/117

@github-actions
Copy link

github-actions bot commented May 22, 2025

preview available: https://docs.tds.cscs.ch/117

@bcumming bcumming merged commit 879cc8d into eth-cscs:main May 23, 2025
1 check passed
@bcumming bcumming deleted the waldur-images branch June 30, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msimberg msimberg msimberg approved these changes

@RMeli RMeli Awaiting requested review from RMeli RMeli is a code owner

@rubber-duck-debug rubber-duck-debug Awaiting requested review from rubber-duck-debug

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bcumming @msimberg