-
Notifications
You must be signed in to change notification settings - Fork 41
Kubernetes docs #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes docs #188
Conversation
|
preview available: https://docs.tds.cscs.ch/188 |
msimberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eliaoggian! I've made mostly cosmetic suggestions, don't be alarmed by the number of comments.
I can't comment on the content unfortunately.
Would you mind adding yourself (and/or someone else you consider suitable to "own" the kubernetes docs) as a codeowner to https://github.com/eth-cscs/cscs-docs/blob/main/.github/CODEOWNERS? All it means you'll be requested as a reviewer whenever changes are made to the listed pages.
|
preview available: https://docs.tds.cscs.ch/188 |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
|
preview available: https://docs.tds.cscs.ch/188 |
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
|
preview available: https://docs.tds.cscs.ch/188 |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
This comment has been minimized.
This comment has been minimized.
|
preview available: https://docs.tds.cscs.ch/188 |
1 similar comment
|
preview available: https://docs.tds.cscs.ch/188 |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
|
preview available: https://docs.tds.cscs.ch/188 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
preview available: https://docs.tds.cscs.ch/188 |
This comment has been minimized.
This comment has been minimized.
bcumming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for the updates.
I have one little fix for the headers, then we can merge.
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
|
preview available: https://docs.tds.cscs.ch/188 |
2 similar comments
|
preview available: https://docs.tds.cscs.ch/188 |
|
preview available: https://docs.tds.cscs.ch/188 |
|
preview available: https://docs.tds.cscs.ch/188 |
|
preview available: https://docs.tds.cscs.ch/188 |
Added kubernetes cluster documentation. This is the migration of the doc that was on KB. Updated some outdated details.