Skip to content

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Jul 17, 2025

No description provided.

@jgphpc jgphpc requested review from Copilot and removed request for RMeli, bcumming and msimberg July 17, 2025 10:46
@jgphpc jgphpc self-assigned this Jul 17, 2025
@github-actions

This comment has been minimized.

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/204

@github-actions

This comment has been minimized.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new documentation page for Score-P and other VI-HPS performance tools, updates the devtools index to reference it, and assigns ownership for the new docs.

  • Add docs/software/devtools/vihps.md covering Score-P, Vampir, Cube & Scalasca, and usage examples
  • Update docs/software/devtools/index.md to include a link to the VI-HPS tools section
  • Extend .github/CODEOWNERS to assign an owner for the new documentation

Reviewed Changes

Copilot reviewed 3 out of 8 changed files in this pull request and generated 2 comments.

File Description
docs/software/devtools/vihps.md New guide for Score-P and related VI-HPS tools
docs/software/devtools/index.md Added “[VI-HPS Tools]” entry to the devtools list
.github/CODEOWNERS Added ownership for docs/software/devtools/vihps
Comments suppressed due to low confidence (3)

docs/software/devtools/vihps.md:29

  • The reference [ref-uenv] isn’t defined in this file. Either add a link definition (e.g. at the bottom) or convert it to an inline URL to avoid a broken link.
The VI-HPS uenv is named `scorep` and it can be loaded into your environment as explained here and in the [uenv documentation][ref-uenv].

docs/software/devtools/vihps.md:81

  • [nitpick] Grammar: change "one of the report type" to "one of the report types" for correct pluralization.
    Pick one of the report type in your jobscript before running the executable compiled with `scorep`:

docs/software/devtools/vihps.md:1

  • [nitpick] This anchor syntax is uncommon—please verify it renders correctly or consider using a more standard Markdown heading ID (e.g. ## VI-HPS tools {#ref-devtools-vihps}) for consistency.
[](){#ref-devtools-vihps}

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/204

@jgphpc jgphpc requested a review from bcumming July 17, 2025 10:54
Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks JG!

I have a few nit picks.

The main one is that the images of the product logos are not needed, and would increase the size of the repository by 230kb.

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/204

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/204

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/204

@jgphpc

This comment was marked as resolved.

@bcumming bcumming enabled auto-merge July 18, 2025 11:17
@bcumming bcumming added this pull request to the merge queue Jul 18, 2025
Merged via the queue into eth-cscs:main with commit 3ddd89e Jul 18, 2025
3 checks passed
@jgphpc jgphpc deleted the scorep branch July 18, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants