Skip to content

Conversation

@RMeli
Copy link
Member

@RMeli RMeli commented Apr 11, 2025

Documentation update related to eth-cscs/alps-uenv#204.

@RMeli RMeli requested review from bcumming and msimberg as code owners April 11, 2025 14:08
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bcumming
Copy link
Member

The build is failing because the Eiger page isn't there.
Luca plans to add the page, but maybe we should create an empty TODO page for eiger, so that we can start linking to it?

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/86

Co-authored-by: Ben Cumming <bcumming@cscs.ch>
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/86

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/86

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/86

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@RMeli
Copy link
Member Author

RMeli commented Apr 30, 2025

There seem to be some very rudimentary support to support ignoring code blocks, but I can't see it in the release notes. See check-spelling/check-spelling#9 for a discussion. Should we try the prerelease version?

check-spelling: block ignore

@msimberg
Copy link
Collaborator

msimberg commented Apr 30, 2025

There seem to be some very rudimentary support to support ignoring code blocks, but I can't see it in the release notes. See check-spelling/check-spelling#9 for a discussion. Should we try the prerelease version?

check-spelling: block ignore

Nice find! I opened #103 against this PR to try it out. It seems to indeed ignore code blocks this way (which may be too severe, but probably better this way to silence a bit more of the noise for now; code blocks are very likely to contain non-words... but also typos 🤷).

Do you maybe want to quickly try it out on this PR, and we can still decide after that if we keep it or not?

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/86

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/86

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/86

@RMeli
Copy link
Member Author

RMeli commented Apr 30, 2025

@msimberg I added a pattern to ignore inline code blocks too. Looks like now only the actual spelling mistake in the text remains.

It seems to indeed ignore code blocks this way (which may be too severe, but probably better this way to silence a bit more of the noise for now; code blocks are very likely to contain non-words... but also typos 🤷).

I totally agree that typos will remain in the code blocks, but I think this is a win for now, and we can always port unknown words from the code blocks to the allow.txt file later on, once the documentation is a bit more stable?

@RMeli RMeli requested review from bcumming and msimberg April 30, 2025 11:39
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/86

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/86

\]\[[a-z-]+\]

# Inline code
\`[^\`]+\`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: perhaps this is safer:

Suggested change
\`[^\`]+\`
\`[^\` ]+\`

? I'm not sure if it will otherwise exclude things in between inline code blocks as well, like

long line of `text` wiht mnay tyops `between` inline code

I think most inline code is just a single word without spaces?

Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question on the spell checking whitelist, but looks good to me otherwise.

@bcumming bcumming merged commit 685a045 into main Apr 30, 2025
2 of 3 checks passed
@bcumming bcumming deleted the namd-eiger branch April 30, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants