fix(release): override scoped package name in build via extraMetadata#49
Merged
Conversation
…ates PR #47 added linux.executableName to fix snap's `--executable` flag and the deb binary name — but the deb / snap output PATHS still come from electron-builder's default artifactName templates which use the ${name} token (= package.json#name). That's now `@etherpad/desktop` (scoped after the monorepo move), so: - deb / snap write to `release/@etherpad/desktop_*` and crash with "Parent directory does not exist: release/@etherpad" - Windows NSIS intermediate `release/@etherpaddesktop-*.nsis.7z` trips 7za's `@listfile` convention and fails with "Could not create destination file: No such file or directory" Setting `extraMetadata.name: etherpad-desktop` in the electron-builder config overrides package.json#name at build time without touching the actual package.json (which we need to keep as `@etherpad/desktop` for `pnpm --filter` and workspace deps). Every artifact template that interpolates ${name} now sees the slash-free name and the path issue goes away in one move. Verified by inspecting the v0.4.1 build logs for both remaining failures: - linux deb: fpm `--p ... cannot write to release/@etherpad/desktop_0.4.1_amd64.deb` - snap: mksquashfs `Could not create destination file` on the same path shape (release/@etherpad/desktop_0.4.1_amd64.snap) - win nsis: 7za `Could not create destination file` on release\@etherpaddesktop-0.4.1-x64.nsis.7z (@-prefix triggers 7za's @ListFile mode) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #47. That PR fixed:
But the v0.4.1 rebuild surfaced three remaining failures that all share the same root cause: `package.json#name` is `@etherpad/desktop` (scoped after the monorepo move), and electron-builder's `${name}` token appears in artifact templates we don't control directly:
Fix
`extraMetadata.name: etherpad-desktop` in the electron-builder config. This overrides `package.json#name` at build time only — the workspace package keeps its scoped name so `pnpm --filter @etherpad/desktop` and workspace deps continue to work.
This is the single, narrowest place to fix all three at once. Each artifact template that interpolates `${name}` now sees the slash-free `etherpad-desktop`.
Test plan
Notes
🤖 Generated with Claude Code