-
Notifications
You must be signed in to change notification settings - Fork 274
Fix images links #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix images links #1694
Conversation
…documentation for consistency
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis set of changes updates documentation and word list files. Image paths for diagrams in two documentation pages ( Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pages/superchain/superchain-explainer.mdx (1)
31-31: Add an Oxford comma before “and more”Project style → lists need the Oxford comma.
Suggested tweak:-... upgrades, a communication layer and more, all built on the OP Stack. +... upgrades, a communication layer, and more, all built on the OP Stack.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
pages/operators/chain-operators/tools/op-conductor.mdx(1 hunks)pages/stack/fault-proofs/cannon.mdx(1 hunks)pages/superchain/superchain-explainer.mdx(1 hunks)words.txt(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.mdx
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
🧠 Learnings (3)
📓 Common learnings
Learnt from: qbzzt
PR: ethereum-optimism/docs#1216
File: pages/stack/interop/security.mdx:136-144
Timestamp: 2025-01-08T11:04:45.361Z
Learning: In the ethereum-optimism/docs repository, sections that are commented out in documentation files are intentionally excluded due to accuracy concerns and should not be suggested for inclusion until the information becomes accurate.
Learnt from: sbvegan
PR: ethereum-optimism/docs#1001
File: pages/builders.mdx:11-12
Timestamp: 2024-10-22T02:58:02.175Z
Learning: Prefer using 'OP Stack' over 'OP Mainnet' in documentation for consistency.
pages/superchain/superchain-explainer.mdx (1)
Learnt from: sbvegan
PR: ethereum-optimism/docs#1001
File: pages/builders.mdx:11-12
Timestamp: 2024-10-22T02:58:02.175Z
Learning: Prefer using 'OP Stack' over 'OP Mainnet' in documentation for consistency.
words.txt (1)
Learnt from: sbvegan
PR: ethereum-optimism/docs#1001
File: pages/builders.mdx:11-12
Timestamp: 2024-10-22T02:58:02.175Z
Learning: Prefer using 'OP Stack' over 'OP Mainnet' in documentation for consistency.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (4)
pages/stack/fault-proofs/cannon.mdx (1)
40-40: Image path verified
The SVGfault-proof-control-flow.svgexists atpublic/img/op-stack/protocol/fault-proof-control-flow.svg, so referencing it as/img/op-stack/protocol/fault-proof-control-flow.svgis correct. No changes needed.pages/operators/chain-operators/tools/op-conductor.mdx (1)
53-53: Diagram path confirmedThe file
public/img/builders/chain-operators/op-conductor.svgexists, so the referencewill resolve correctly.
words.txt (2)
91-92: LGTM – lowercase “datadir” variant addedLower-case form complements existing “DATADIR” and maintains casing consistency.
268-268: LGTM – lowercase “offchain” variant addedMatches the convention used for other camel-/capitalized entries.
Description
Tests
Additional context
Metadata