-
Notifications
You must be signed in to change notification settings - Fork 274
privileged-roles address updates #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update privileged-roles.mdx
WalkthroughThe latest update in the Changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional context usedPath-based instructions (1)
LanguageTool
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
pages/chain/security/privileged-roles.mdx (1)
Line range hint
21-21: Consider varying the sentence structure to avoid repetition.- Compromised L1 Proxy Admin could upgrade contracts to malicious versions. - Compromised L1 Proxy Admin could remove or lock ETH or tokens in the Standard Bridge. - Compromised L1 Proxy Admin could fail to mitigate a risk as described on this page. + The L1 Proxy Admin could upgrade contracts to malicious versions, remove or lock ETH or tokens in the Standard Bridge, and potentially fail to mitigate risks as described on this page.Also applies to: 40-40, 64-64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to double check the address change for the L2ProxyAdmin
Co-authored-by: George Knee <georgeknee@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
pages/chain/security/privileged-roles.mdx (1)
34-40: Ensure clarity and accuracy in the explanation of address aliasing.The explanation of address aliasing in lines 36-39 is crucial but could be confusing for readers unfamiliar with the concept. Consider adding a more detailed explanation or a visual diagram to enhance understanding. Also, ensure the external link to the
AddressAliasHelperlibrary is always up-to-date to maintain the reliability of the documentation.
| ### Addresses | ||
|
|
||
| * **Ethereum**: [`0x9BA6e03D8B90dE867373Db8cF1A58d2F7F006b3A`](https://etherscan.io/address/0x9BA6e03D8B90dE867373Db8cF1A58d2F7F006b3A) | ||
| * **Ethereum**: [`0x09f7150D8c019BeF34450d6920f6B3608ceFdAf2`](https://etherscan.io/address/0x09f7150D8c019BeF34450d6920f6B3608ceFdAf2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the Ethereum address for the Guardian role.
The Ethereum address for the Guardian role has been updated to 0x09f7150D8c019BeF34450d6920f6B3608ceFdAf2. Please ensure this address is correct and active by verifying it on Etherscan. Additionally, consider adding a brief description or note about why this address was changed, to maintain historical context for future reference.
Update privileged-roles.mdx