-
Notifications
You must be signed in to change notification settings - Fork 274
feat: added wip callout feature #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WalkthroughThis update introduces the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
participant WipCallout Component
participant WipMsg Content
User->>Documentation: Visits a tutorial page
Documentation->>WipCallout Component: Renders callout component
WipCallout Component->>WipMsg Content: Fetches maintenance message
WipMsg Content-->>WipCallout Component: Returns message content
WipCallout Component-->>Documentation: Displays maintenance message
Documentation-->>User: Shows updated tutorial with maintenance callout
sequenceDiagram
participant Developer
participant tsconfig.json
participant messages/WipMsg.md
participant components/WipCallout.tsx
participant Application
Developer->>tsconfig.json: Adds new path mappings
Developer->>messages/WipMsg.md: Creates maintenance message
Developer->>components/WipCallout.tsx: Creates `WipCallout` component
Application->>components/WipCallout.tsx: Imports and uses `WipCallout`
components/WipCallout.tsx->>messages/WipMsg.md: Fetches maintenance message content
messages/WipMsg.md-->>components/WipCallout.tsx: Returns message content
components/WipCallout.tsx-->>Application: Renders maintenance callout
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (2)
words.txt (1)
Line range hint
1-350: Address duplication in word list.The list contains several instances where words are duplicated in different cases (e.g., "ACCOUNTQUEUE" and "accountqueue"). This might be intentional for case-insensitive matching, but if not necessary, consider removing duplicates to streamline the list.
Tools
LanguageTool
[duplication] ~132-~132: Möglicher Tippfehler: ein Wort wird wiederholt (GERMAN_WORD_REPEAT_RULE)
Context: ...lesky IGNOREPRICE ignoreprice implicity Inator inator INFLUXDBV influxdbv initcode IPCDISABLE...
[duplication] ~134-~134: Möglicher Tippfehler: ein Wort wird wiederholt (GERMAN_WORD_REPEAT_RULE)
Context: ...ICE ignoreprice implicity Inator inator INFLUXDBV influxdbv initcode IPCDISABLE ipcdisable ipcfile ...
[duplication] ~137-~137: Möglicher Tippfehler: ein Wort wird wiederholt (GERMAN_WORD_REPEAT_RULE)
Context: ...tor inator INFLUXDBV influxdbv initcode IPCDISABLE ipcdisable ipcfile IPCPATH ipcpath IPFS ipfs JALR ...pages/builders/app-developers/tutorials/cross-dom-bridge-erc20.mdx (1)
Line range hint
1-343: Comprehensive review of the tutorial content.The tutorial is well-structured and informative. The step-by-step instructions are clear, and the code snippets appear to be correct. However, consider the following improvements for clarity and variety in phrasing:
- In the section about the Standard Bridge, consider rephrasing "if you want to learn more" to "to learn more" for a stronger, more direct expression.
- Avoid repetitive phrasing such as "if you want to use" by substituting with alternatives like "to use" or "for using".
These changes will enhance the readability and engagement of the tutorial.
- if you want to learn more about how the bridge works + to learn more about how the bridge works - If you want to use a network that isn't included by default + To use a network that isn't included by default
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
- added RNG section - added RNG info to providers that support it - added 2 providers: API3 and Chronicle
add gelato
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
the constructor's bridge params should be L2StandardBridge.sol deployed address, not L2CrossDomainMessenger's address
Chainstack's been an OP node provider for a 1.5 years as of today. We are also providing the free OP nodes as one of the default options in ethers. See here ethers-io/ethers.js#4762
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 7
Outside diff range and nitpick comments (3)
pages/connect/contribute/stack-contribute.mdx (1)
Line range hint
38-38: Add a comma for clarity.Adding a comma after "YOU" will improve the readability of the sentence.
- The OP Stack needs YOU (yes you!) to help review the codebase for bugs and vulnerabilities. + The OP Stack needs YOU (yes, you!) to help review the codebase for bugs and vulnerabilities.Tools
LanguageTool
[style] ~19-~19: Consider replacing this word to strengthen your wording.
Context: ...ck is a decentralized development stack and is constantly evolving as new layers an...(AND_THAT)
[uncategorized] ~19-~19: Possible missing comma found.
Context: ...s that can be considered part of the OP Stack as long as those components fit the sta...(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~20-~20: For a more polite and respectful tone, consider rephrasing with ‘please’.
Context: ...contributions) and get to building! And don't forget that projects can also receive grants f...(DONT_FORGET)
pages/builders/chain-operators/architecture.mdx (1)
Line range hint
14-14: Correct grammatical issues and improve clarity.Several sentences need minor adjustments for grammatical correctness and clarity.
- This page contains information about the components of the rollup protocol and how they work together to build the layer 2 blockchain from the Chain Operator's perspective. + This page contains information about the components of the rollup protocol and how they work together to build a layer 2 blockchain from the Chain Operator's perspective. - `op-geth` implements the layer 2 execution layer, with [minimal changes](https://op-geth.optimism.io/) + `op-geth` implements the layer 2 execution layer with [minimal changes](https://op-geth.optimism.io/) - `op-node` implements most rollup-specific functionality as the layer 2 consensus layer, similar to a layer 1 beacon-node. + `op-node` implements most rollup-specific functionality as a layer 2 consensus layer, similar to a layer 1 beacon-node. - It is important to setup a robust chain architecture to handle large volumes of RPC requests from your users. + It is important to set up a robust chain architecture to handle large volumes of RPC requests from your users. - This tool is a RPC request router and proxy. + This tool is an RPC request router and proxy.Also applies to: 33-33, 39-39, 54-54, 68-68
pages/builders/tools/build/oracles.mdx (1)
Line range hint
30-30: Grammar correction: Hyphenation needed.- always have up to date information available onchain. + always have up-to-date information available onchain.Ensure that "up-to-date" is hyphenated to maintain grammatical correctness.
Tools
LanguageTool
[typographical] ~23-~23: Consider adding a comma after ‘Usually’ for more clarity.
Context: ...d different levels of decentralization. Usually they are either run by the organization...(RB_LY_COMMA)
Description
Adds support for custom callout messages in the
WipCalloutcomponent. This feature allows you to add a custom callout to a page, notifying users that it is currently undergoing maintenance.Additional context
This is an image showing that the callout sticks to the top when the page is scrolled
The color scheme is open for suggestions, and I'll update this PR accordingly.
Example link:
http://localhost:3000/builders/app-developers/tutorials/cross-dom-bridge-erc20