-
Notifications
You must be signed in to change notification settings - Fork 808
Add PepeCommunity (PEPE) token for Ethereum → Base bridge #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
data/PEPE_0xBE/data.json
Outdated
| "address": "0xbe042e9d09cb588331ff911c2b46fd833a3e5bd6" | ||
| }, | ||
| "base": { | ||
| "address": "0xPUT_YOUR_BASE_DEPLOYED_ADDRESS_HERE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0xb5068ad7e4ad8f7fe2fcf5abe2c043ab8866569c
|
Hi @xxDTECHxx your PR is failing, I think likely because it doesn't contain the actual address on Base. Please fix and feel free to tag me when done for a re-review! |
|
@fainashalts Hey there! |
|
@fainashalts checking in if you are able to assist now! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Financial
More Details
| Attribute | Value |
|---|---|
| Data Classifier | Financial/Ethereum Address |
| Data Classifier ID | BUILTIN-388 |
Sampled Examples
| Key | Value |
|---|---|
| ethereum.address | 0x*42...**d6 (42 chars) |
Rule ID: BUILTIN-388
To ignore this finding as an exception, reply to this conversation with #wiz_ignore reason
If you'd like to ignore this finding in all future scans, add an exception in the .wiz file (learn more) or create an Ignore Rule (learn more).
|
HI @xxDTECHxx thank you so much for your patience - we had an issue with rate limiting which I just fixed. Can you rebase this PR against master? I'm pretty sure it will pass CICD after you do that and then I can merge! |
|
@fainashalts artifact errors in Circle CI validate show timeout on infura again. |
|
HI @xxDTECHxx it looks like your branch is stale - you have to rebase against the latest master to get my fix. Thanks, let me know when this is done and we can get this merged! |
This PR adds the Pepe Community ($PEPE) token to the Superchain Token List for Ethereum and Base.
Deployment on Base will follow the standard OptimismMintableERC20Factory process as recommended by Base bridging documentation. (This was completed and now the L2 Address for Base was populated above. )