feat: optimize apply_formatters_to_sequence#307
Merged
Conversation
Contributor
Author
BobTheBuidler
referenced
this pull request
in BobTheBuidler/faster-eth-utils
Oct 18, 2025
* feat: optimize apply_formatters_to_sequence * Create 307.performance.rst
BobTheBuidler
referenced
this pull request
in BobTheBuidler/faster-eth-utils
Oct 18, 2025
* Decrease strictness of error msg check on set (#313) * Compile release notes for v5.3.1 * Bump version: 5.3.0 → 5.3.1 * feat: optimize apply_formatters_to_sequence (#307) * feat: optimize apply_formatters_to_sequence * Create 307.performance.rst * chore: compile C files for source control --------- Co-authored-by: kclowes <kclowes@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
We can perform this if-check optimistically since we expect it to succeed in most cases
Not a huge difference, but if we can save 2 len() calls per call, let's do it!
Related to Issue #
Closes #
How was it fixed?
Todo:
Cute Animal Picture