Skip to content

Conversation

mkalinin
Copy link
Contributor

What's done?

The engine_preparePayload return type is changed from payloadId|Error to Object|Error for the sake of the future compatibility, i.e. this change allows for adding more data to the response of this method preserving backward compatibility.

@mkalinin
Copy link
Contributor Author

Also, do we want engine_getPayload call accept a request Object rather than payloadId?

@lightclient
Copy link
Member

I think just payloadId is acceptable, since JSON-RPC 2.0 already accepts an arbitrary number of parameters by either position or name.

@lightclient lightclient merged commit bd4389d into ethereum:main Sep 28, 2021
@pomnt
Copy link

pomnt commented Oct 31, 2021

What's done?

The engine_preparePayload return type is changed from payloadId|Error to Object|Error for the sake of the future compatibility, i.e. this change allows for adding more data to the response of this method preserving backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants