Skip to content

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Oct 29, 2021

add safeBlockHash to engine_forkchoiceUpdated.

note that until a safeBlockHash algorithm for CL is cleanly defined that CL will always submit safeBlockHash = headBlockHash.

Also note that this value is not critical to the consensus of EL but only to be utilized for user facing APIs

@djrtwo djrtwo requested review from dankrad and lightclient October 29, 2021 19:11
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good - not sure if understand the need for both a finalizedBlockHash and safeBlockHash though.

@djrtwo
Copy link
Contributor Author

djrtwo commented Oct 30, 2021

Under normal network conditions, safe is nearly the head if not the head. Safe will not be reorged if certain amount of attestations have been seen, certain synchrony assumption, and honestly assumption. This is useful to potentially display in apis (as opposed to the bleeding edge consensus head)

Finalized is much deeper in chain and has a very strong cryptoeconomic guarantee non reversion

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djrtwo djrtwo merged commit 96742bf into main Nov 1, 2021
@djrtwo djrtwo deleted the safe-head branch November 1, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants