Skip to content

Conversation

mkalinin
Copy link
Contributor

Defines a versioning mechanism for methods and structures and sets initial versions.

@mkalinin mkalinin force-pushed the engine-api-versioning branch from e4e17d2 to 326f59e Compare October 30, 2021 07:50
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable. I'd like to get some input from @holiman or others that took part more in the convo at amphora

@mkalinin
Copy link
Contributor Author

mkalinin commented Nov 1, 2021

cc @lightclient, @protolambda

@ralexstokes
Copy link
Member

there are a number of ways to handle this and they all have different trade-offs...

in the interest of not bike-shedding, i think versioning the JSON-RPC method name itself is fine.

unless someone else can chime in and express i strong preference otherwise, i say we merge this!

@holiman
Copy link
Contributor

holiman commented Nov 1, 2021

Yeah, I guess this is reasonable. It's not beautiful, but I guess it's what we agreed.

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish the JSON-RPC had better versioning options, but this works. Versioning an API from the start is the best kind of versioning, LGTM.

@djrtwo djrtwo merged commit c859f93 into ethereum:main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants