history file location isn't configurable

[tom-seddon]

Shouldn't --datadir influence where the history file goes?

root@508700517ebc:/# geth --datadir /data attach ipc:/data/geth.ipc
unable to open history file: open /root/.ethereum/history: no such file or directory

(The "unable to open history file" error message also gets printed to stdout.)

--Tom

[karalabe]

The issue is that when only attaching, we create a lightweight JS interpreter (https://github.com/ethereum/go-ethereum/blob/develop/cmd/geth/main.go#L429), and we do not pass an ethereum configuration (which contains the actual datadir parameter) to it. Hence setting the data dir (https://github.com/ethereum/go-ethereum/blob/develop/cmd/geth/js.go#L439) never happens. The solution would be to extract the needed configuration options manually and pass them to the lightweight JSRE too.

[karalabe]

If/when you have time, @bas-vk, could you look at this?

[tgerring]

@tom-seddon Can you check against latest develop to see if your problem is now resolved? The fix should now be merged in

[zelig]

this has been fixed. closing