accounts/abi: shadow loop variables in TestPack to fix parallel subtest capture #32810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashass1315
requested review from
MariusVanDerWijden and
gballet
as code owners
This is not needed anymore after go 1.22. Since we only target the last two releases, this is unnecessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shadow loop variables i and test before t.Run in TestPack to prevent closure capture issues when running subtests with t.Parallel(). Without shadowing, all parallel subtests may read mutated loop variables, causing flaky and non-deterministic assertions. This change ensures each subtest operates on the correct iteration values. No functional logic changes; test stability only.