core: use scheme-aware empty root in flushAlloc #33168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
approved these changes
Nov 13, 2025
atkinsonholly
pushed a commit
to atkinsonholly/ephemery-geth
that referenced
this pull request
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flushAlloc() routine used a hard-coded check against types.EmptyRootHash to decide whether to commit state to triedb. This is incorrect when the trie is Verkle, where the empty root is types.EmptyVerkleHash. As a result, an empty Verkle genesis (no alloc) would still trigger triedb.Commit, which can fail because there are no diff layers to persist. This change compares the computed root against the scheme-appropriate emptyRoot selected earlier in the function, ensuring we do not commit a truly empty state for both MPT and Verkle.