Skip to content

Conversation

@marioevz
Copy link
Member

@marioevz marioevz commented May 2, 2023

This PR extracts the following components into their own repository:
./simulators/eth2/common/builder -> https://github.com/marioevz/mock-builder
./simulators/eth2/common/clients -> https://github.com/marioevz/eth-clients

Reason is being able to use mock-builder as an external command, and this requires the structs and interfaces declared in eth-clients.

This results in removing lot of code from ./simulators/eth2/common to make it more reusable.

Other fixes included:

  • Slot time configuration is now part of the common library and automatically configured for clients that don't support 6s slots
  • Incremental forks are removed (trick to start from phase0 up to bellatrix/capella in order for some clients to work, no longer necessary)
  • Fix TTD > 0 setup in eth2/engine

@marioevz marioevz requested a review from fjl May 3, 2023 00:30
@marioevz marioevz force-pushed the extract-builder-and-clients branch from 489ad89 to adb5e81 Compare May 12, 2023 15:42
@marioevz
Copy link
Member Author

Rebased to main to fix geth not working due to PoW.

@marioevz
Copy link
Member Author

I'll finish up running the simulators with the change and merge in a few hours unless objections 👍 @fjl

@marioevz marioevz merged commit 3d5dbc6 into ethereum:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant