Fail gracefully if solc doesn't find any contracts. Information how t… #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o install solc. Watch out for py.test / tox caches.
| def test_compile_empty_folder(): | ||
| """Execute compile on a folder without contracts.""" | ||
|
|
||
| with tempfile.TemporaryDirectory() as tmpdirname: |
Member
There was a problem hiding this comment.
I think this isn't python2 compatable.
You can do this with the tmpdir fixture provided by pytest.
def test_things(tmpdir):
dir_that_will_be_auto_cleaned_up = str(tmpdir.mkdir('some-dir'))
... # do things.
Member
|
Also two linting errors. |
Member
|
Just the two small cleanup items and I'll get this merged and released. |
Contributor
Author
|
Done. |
Member
|
Available as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
If solc did not find any contracs in given folder JSON output was not properly managed.
How was it fixed?
Raise an exception if solc doesn't find any contracts.
Updates regarding solc installation instructions, .gitignore.
Cute Animal Picture