Skip to content

use the solc_binary argument (and gevent.subprocess) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 18, 2016
Merged

use the solc_binary argument (and gevent.subprocess) #5

merged 3 commits into from
Aug 18, 2016

Conversation

@pipermerriam
Copy link
Member

@pipermerriam pipermerriam commented Aug 7, 2016

What was wrong?

The solc_binary argument was being ignored by solc.wrapper.solc_wrapper

How was it fixed?

Changed the function to use the argument.

  • [] TODO: Still need to work out how to get it correctly passed into the other places like get_solc_version().

Cute Animal Picture

put a cute animal picture here.

@pipermerriam pipermerriam changed the title use the solc_binary argument use the solc_binary argument (and gevent.subprocess) Aug 18, 2016
@pipermerriam pipermerriam merged commit c50f436 into master Aug 18, 2016
@pipermerriam pipermerriam deleted the piper/actually-use-solc-binary-argument branch August 18, 2016 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pipermerriam