Skip to content

Conversation

@kaisert
Copy link

@kaisert kaisert commented Oct 3, 2018

What was wrong?

solc version 0.4.25 was not supported in the install scripts

How was it fixed?

added version

Cute Animal Picture

luna

Copy link
Contributor

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a job to Travis to test v0.4.25? https://github.com/ethereum/py-solc/blob/master/.travis.yml

Also, we bump versions immediately before deploying, instead of every PR. Would you drop the commit and force push?

@kaisert kaisert force-pushed the update-to-v0.4.25 branch from 73d65ae to e4176a2 Compare October 4, 2018 08:02
@pipermerriam pipermerriam merged commit 6607144 into ethereum:master Oct 4, 2018
@pipermerriam
Copy link
Member

Released under v3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants