This repository was archived by the owner on May 23, 2023. It is now read-only.
Add factory for tester.state with recent fork-level #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Simple and nice. Looks good to me. Let's see if the tests pass. |
Member
|
@mfranciszkiewicz, can you review this? |
A common pitfall for developers is using vanilla `tester.state` with contracts that use more recent opcodes (ending up with `invalid opcode` errors). The factory function `latest_state`, prepares the state for any developer with the latest fork block number (as set in ethereum.config.LATEST_FORK_BLKNUMBER). This way, legacy applications won't change their behavior, but newer users/ developers can be encouraged to just use `latest_state()`. Since inception of this PR, this got rebased on latest develop to now point to the ANTI_DOS_FORK.
konradkonrad
force-pushed
the
latest_tester_state
branch
from
df8a4ec to
97ec956
Compare
ethereum/tester.py
Outdated
| """ | ||
| blockchain_state = state(**kwargs) | ||
|
|
||
| if blknum is not None: |
There was a problem hiding this comment.
I believe you meant if blknum is None here, otherwise blockchain_state.block.number is either LATEST_APPLIED_FORK_BLKNUM + 1 or None.
Contributor
Author
There was a problem hiding this comment.
:doh:
Thanks for spotting this! That was a pretty terrible LOC/error ratio 😮
Fixed and added tests!
This fixes an error with the `blknum` parameter and changes the logic to set the state to the actual `LATEST_APPLIED_FORK_BLKNUM` (instead of `+ 1`), since rules are applied starting from the block. Also added tests to ensure the intended behavior.
mfranciszkiewicz
added a commit
to golemfactory/golem-crowdfunding
that referenced
this pull request
Nov 2, 2016
EIP150 starting block (to be refactored after ethereum/pyethereum#411 is merged) Tester gas limit set to 2 mil
Contributor
Author
|
I don't think this will ever be merged...closing it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common pitfall for developers is using vanilla
tester.statewith contractsthat use more recent opcodes (ending up with
invalid opcodeerrors).The factory function
latest_state, prepares the state for any developer withthe latest fork block number (as set in ethereum.config.LATEST_FORK_BLKNUMBER).
This way, legacy applications won't change their behavior, but newer users/
developers can be encouraged to just use
latest_state().