Skip to content

Conversation

@joeizang
Copy link
Collaborator

@joeizang joeizang commented Jun 30, 2021

Fixes #1493

Copy link

@Hbutlercapone Hbutlercapone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve merge #1344

@joeizang
Copy link
Collaborator Author

Looks very good although I found some small issues.

  1. I activated 3box plugin(on mainview plugin) the icon is there but not the tab. and when you click activate again it will throw an error. (live was fine)
  2. Permissions modal contains empty rectangle when empty (div's border)
  3. warning when I put value to local plugin modal field(URL)
  4. Can't create a plugin on mainview(probably same issue as 1)

Points 2 and 3 have been addressed. Points 1 and 4 were addressed by @bunsenstraat's comments above

@joeizang joeizang dismissed LianaHus’s stale review August 24, 2021 21:48

see comments above

@Aniket-Engg
Copy link
Collaborator

Aniket-Engg commented Aug 25, 2021

Screenshot 2021-08-25 at 12 59 55 PM

It doesn't show Deploy and Run Transactions as active plugin

Actually I see it is not there in the plugin list shown on UI

@Aniket-Engg
Copy link
Collaborator

Screenshot 2021-08-25 at 1 10 37 PM

Clicking on blue checkbox shows error in browser console

@bunsenstraat
Copy link
Collaborator

Screenshot 2021-08-25 at 12 59 55 PM

It doesn't show Deploy and Run Transactions as active plugin

Actually I see it is not there in the plugin list shown on UI

it's not supposed to be. it's an internal plugin.

@Aniket-Engg
Copy link
Collaborator

Screenshot 2021-08-25 at 12 59 55 PM It doesn't show `Deploy and Run Transactions` as active plugin Actually I see it is not there in the plugin list shown on UI

it's not supposed to be. it's an internal plugin.

ah ok.

@joeizang
Copy link
Collaborator Author

Screenshot 2021-08-25 at 1 10 37 PM

Clicking on blue checkbox shows error in browser console

I believe I have resolved the issue @Aniket-Engg. In live, even if the checkbox is unchecked, it doesn't change the state of the permission in localStorage.

@joeizang joeizang requested a review from Aniket-Engg August 25, 2021 11:07
@Aniket-Engg
Copy link
Collaborator

Screenshot 2021-08-25 at 1 10 37 PM Clicking on blue checkbox shows error in browser console

I believe I have resolved the issue @Aniket-Engg. In live, even if the checkbox is unchecked, it doesn't change the state of the permission in localStorage.

Yes these errors are gone

@bunsenstraat bunsenstraat enabled auto-merge August 26, 2021 09:27
@bunsenstraat bunsenstraat merged commit 5b546a7 into master Aug 26, 2021
@bunsenstraat bunsenstraat deleted the react-plugin-manager branch August 26, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move PluginManager To Reactjs.