ipfs pull fallbacks in dgit provider #1519
Merged
+53
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
reviewed
Aug 25, 2021
| protocol: 'https', | ||
| ipfsurl: 'https://ipfs.io/ipfs/' | ||
| } | ||
| this.remixIPFS = { |
Contributor
There was a problem hiding this comment.
ipfsconfig already uses the same URL, is that wanted?
Collaborator
Author
There was a problem hiding this comment.
ipfsconfig is set by the dgit client. so it can be anything. so it's not a duplicate per se.
yann300
reviewed
Aug 25, 2021
lint up timeout
yann300
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's unclear sometimes which IPFS node will response with data. I've seen 'too many requests' errors on ipfs.io and so on...
so this picks the first one that has the files. sometimes the hash is not available yet on any of the nodes. this can still happen if you push to pinata. it takes a few minutes before public nodes have the hash. it also adds a timeout for the request.
it also returns a warning when the local storage is full, which happens more quickly than you'd think.
@ioedeveloper Manual testing: this is hard to test. it actually also needs #1532
otherwise the plugin call will timeout before the first timeout of the IPFS request will timeout....