optimize circleCI #2868

bunsenstraat · 2022-09-03T05:26:50Z

add split paralel by previous runtimes. it's based on names in the results json.
replace pauses as much as possible by assertions ( still a lot to do there ). we should also avoid using assert.containsText for elements in react. but use xpath selectors with contains attribute and then wait on it. this needs more work.
fix some flaky tests. among others force recompiling when imports are slow.
use only compilers on localhost by downloading them in the production assets at e2e build. a script manages this and greps the test files for soljson nightly references. all major versions are automatically included. but only for e2e.
an env variable is passed to the build process to tell the app to use another url for loading compilers.
use matrix configuration in circle. see below.
automatic splitting of tests into jobs that have a separate generic job - containing paralel tests - so we can restart easier without having to run ALL the tests again. FASTER! SUCCESS!! if a job only contains a couple of tests it will pass easier.
runtime is about 7 minutes now
in config.yml you can find:

            parameters:
              browser: ["chrome", "firefox"]
              script: ["browser_test.sh"]
              job: ["0","1","2","3","4","5","6","7","8","9"]
              jobsize: ["10"]

pipe all tests into a single result: tests-passed. this means matrix can be upscaled or downscaled at will. when you need to isolate some tests. We will have to config github to just list that test as required.
each job still has paralel runs but theoretically of course you could have 20 jobs with little or no parallelism.
the app created hidden spans containing information about the loading status of the compiler, the editor, the types files etc this is used by e2e to check if the load has completed
shorten config file with paramater usage

vercel · 2022-09-03T05:26:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
remix-project	✅ Ready (Inspect)	Visit Preview	Sep 21, 2022 at 10:42AM (UTC)

…oject into optimizecircle

Aniket-Engg · 2022-09-21T07:49:45Z

apps/remix-ide-e2e/src/commands/addFile.ts

+      timeout: 2000
+    }, (okVisible) => {
+      // @ts-ignore
+      if (okVisible.status === 0) {


Can you please add a comment explaining okVisible.status

Aniket-Engg · 2022-09-21T07:52:36Z

apps/remix-ide-e2e/src/commands/addFile.ts

          .sendKeys('*[data-id$="/blank"] .remixui_items', browser.Keys.ENTER)
-          .pause(2000)
-          .waitForElementVisible(`li[data-id="treeViewLitreeViewItem${name}"]`, 60000)
+          .isVisible({


same here to use .isVisible instead of waitForElementVisible

I think what the problem is that waitForElementVisible first determines the ID of the element and then polls it with isDplayed https://www.selenium.dev/selenium/docs/api/java/org/openqa/selenium/WebElement.html#isDisplayed--
with an interval, and it seems that if React refreshes the page the nightwatch polling command actually retries to calls the protocol action with the wrong ID resulting in an error. isVisible directly uses the isDisplayed command without polling, it's just a direct webdriver command

apps/remix-ide-e2e/src/commands/checkVariableDebug.ts

Aniket-Engg · 2022-09-21T08:45:02Z

apps/remix-ide/ci/browser_test.sh

+TESTFILES=$(node apps/remix-ide/ci/splice_tests.js $2 $3 | circleci tests split --split-by=timings)
 for TESTFILE in $TESTFILES; do
-    npx nightwatch --config dist/apps/remix-ide-e2e/nightwatch.js $TESTFILE --env=$1  || TEST_EXITCODE=1
+    npx nightwatch --config dist/apps/remix-ide-e2e/nightwatch.js dist/apps/remix-ide-e2e/src/tests/${TESTFILE}.js --env=$1  || TEST_EXITCODE=1


please review if this change is required

yes it's required

Aniket-Engg · 2022-09-21T08:46:42Z

apps/remix-ide/ci/download_e2e_assets.js

+const fs = require('fs');
+
+let url = 'https://binaries.soliditylang.org/wasm/list.json'
+let request = require('request');


request has been deprecated

now using axios

libs/remix-ui/editor/src/lib/remix-ui-editor.tsx

Aniket-Engg · 2022-09-21T08:52:44Z

libs/remix-ui/solidity-compiler/src/lib/compiler-container.tsx

          </div>
        </div>
        <div className="px-4">
+          {compilerLoadedVersion ? <span data-id='compilerLoadedVersion' data-version={compilerLoadedVersion}></span> : ''}


please check if it is required

Aniket-Engg · 2022-09-21T08:53:23Z

package.json

    "nightwatch_local_chrome": "yarn run build:e2e && nightwatch --config dist/apps/remix-ide-e2e/nightwatch.js --env=chrome",
    "nightwatch_local_ballot": "yarn run build:e2e && nightwatch --config dist/apps/remix-ide-e2e/nightwatch.js dist/apps/remix-ide-e2e/src/tests/ballot.test.js --env=chrome",
-    "nightwatch_local_ballot_0_4_11": "yarn run build:e2e && nightwatch --config dist/apps/remix-ide-e2e/nightwatch.js dist/apps/remix-ide-e2e/src/tests/ballot_0_4_11.test.js --env=chrome",
+    "nightwatch_local_ballot_0_4_11": "yarn run build:e2e && nightwatch --config dist/apps/remix-ide-e2e/nightwatch.js dist/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.js --env=chrome",


please update the name too with 0_4_14

add paral

b7c5f6f

bunsenstraat self-assigned this Sep 3, 2022

glob

35c6057

vercel bot deployed to Preview September 3, 2022 05:56 View deployment

cmd

fd6f677

vercel bot deployed to Preview September 3, 2022 06:01 View deployment

rm pause

c1a5acd

vercel bot deployed to Preview September 3, 2022 06:05 View deployment

js

3d39702

vercel bot deployed to Preview September 3, 2022 06:08 View deployment

rm pauses

d64fa15

vercel bot deployed to Preview September 3, 2022 06:20 View deployment

more echos

df5b658

vercel bot deployed to Preview September 3, 2022 06:32 View deployment

pipe to artefacts

4ba800c

vercel bot deployed to Preview September 3, 2022 06:34 View deployment

mkdir

0e590fb

vercel bot deployed to Preview September 3, 2022 06:41 View deployment

build e2e

722e591

vercel bot deployed to Preview September 3, 2022 06:49 View deployment

timings

0a1a859

vercel bot deployed to Preview September 3, 2022 06:57 View deployment

output json

bf3b942

vercel bot deployed to Preview September 3, 2022 07:12 View deployment

classname split

13bdf07

vercel bot deployed to Preview September 3, 2022 07:41 View deployment

more output

e0dfc41

vercel bot deployed to Preview September 3, 2022 07:49 View deployment

syntax

e2d2604

10

2c0cb6e

vercel bot deployed to Preview September 20, 2022 19:29 View deployment

bunsenstraat requested a review from Aniket-Engg September 20, 2022 19:37

rm parts

c415dc9

vercel bot deployed to Preview September 20, 2022 19:40 View deployment

bunsenstraat requested review from ioedeveloper and yann300 September 20, 2022 19:46

Delete data.js

0725784

vercel bot deployed to Preview September 20, 2022 21:59 View deployment

filip mertens added 2 commits September 21, 2022 09:21

rename stuff

c2cc939

Merge branch 'optimizecircle' of https://github.com/ethereum/remix-pr…

617a062

…oject into optimizecircle

vercel bot deployed to Preview September 21, 2022 07:23 View deployment

Aniket-Engg reviewed Sep 21, 2022

View reviewed changes

some fixes

4d702ac

vercel bot deployed to Preview September 21, 2022 09:42 View deployment

addfile

c0e75c3

vercel bot deployed to Preview September 21, 2022 09:54 View deployment

reset add file

6036011

vercel bot deployed to Preview September 21, 2022 10:11 View deployment

filip mertens added 2 commits September 21, 2022 12:18

set path

6fde74e

paths

c2df599

vercel bot deployed to Preview September 21, 2022 10:19 View deployment

addcomments

7fdc0b0

vercel bot deployed to Preview September 21, 2022 10:27 View deployment

use axios

43b5f1a

vercel bot deployed to Preview September 21, 2022 10:42 View deployment

Aniket-Engg approved these changes Sep 21, 2022

View reviewed changes

bunsenstraat merged commit 34579ff into master Sep 21, 2022

bunsenstraat deleted the optimizecircle branch September 21, 2022 12:44

bunsenstraat added the browser-tests e2e tests for remix-ide label Sep 21, 2022

optimize circleCI #2868

optimize circleCI #2868

Uh oh!

Conversation

bunsenstraat commented Sep 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Sep 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bunsenstraat commented Sep 3, 2022 •

edited

Loading

vercel bot commented Sep 3, 2022 •

edited

Loading