Skip to content

Pride theme improvements. Fixing the text on the btns on d&r #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yann300 merged 5 commits into from
Jun 26, 2023
Merged

Pride theme improvements. Fixing the text on the btns on d&r #3835

yann300 merged 5 commits into from
Jun 26, 2023

Conversation

@LianaHus
Copy link
Contributor

@LianaHus LianaHus commented Jun 21, 2023 •
edited
Loading

  • fixing some color problems in Pride theme.
  • Fixing the btns text on deploy and run

@netlify
Copy link

netlify bot commented Jun 21, 2023 •
edited
Loading

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit c6158c0
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/64997ffe86acc20008a3e46a
😎 Deploy Preview https://deploy-preview-3835--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@LianaHus LianaHus changed the title fixing some color problems in Pride theme. Fixing the btns text on Pride theme improvements. Fixing the text on the btns on d&r Jun 21, 2023
joeizang
joeizang reviewed Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@joeizang joeizang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The active state of the buttons need a bit of work with contrast. Black text on these buttons really don't work.

@joeizang
Copy link
Collaborator

joeizang commented Jun 21, 2023

image

The button in the debugger requires a bit of work on contrast.

@LianaHus
Copy link
Contributor Author

LianaHus commented Jun 21, 2023

the border is thiner now. The btns are meant to have some colors, this is different from the light theme, but that color is not enough for white.

@yann300 yann300 requested a review from joeizang June 21, 2023 13:51
@Aniket-Engg
Copy link
Collaborator

Aniket-Engg commented Jun 22, 2023

image

The active state of the buttons need a bit of work with contrast. Black text on these buttons really don't work.

I agree on this. Color contrast should be improved

@B-Venkatesh7210
Copy link

B-Venkatesh7210 commented Jun 23, 2023

How can I reject this PR?

@yann300
Copy link
Contributor

yann300 commented Jun 24, 2023

@B-Venkatesh7210
As it's already approved, it will most probably be merged.
If you want more improvements to be done regarding the theming part, please feel free to create an issue. We also welcome any external contribution ofc.

@LianaHus
Copy link
Contributor Author

LianaHus commented Jun 26, 2023

updated @Aniket-Engg @joeizang

@yann300 yann300 requested a review from joeizang June 26, 2023 10:14
@yann300 yann300 force-pushed the placeholderColor branch from 58cf013 to c6158c0 Compare June 26, 2023 12:09
@yann300 yann300 merged commit 947784a into master Jun 26, 2023
@yann300 yann300 deleted the placeholderColor branch June 26, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aniket-Engg Aniket-Engg Aniket-Engg approved these changes

@yann300 yann300 Awaiting requested review from yann300

@joeizang joeizang Awaiting requested review from joeizang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LianaHus @joeizang @Aniket-Engg @B-Venkatesh7210 @yann300