disable verify for not supported VM #3840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
I thought we should have a tooltip on verify btn when it is disabled, it is a good practice to give a hint on disabled btn. |
LianaHus
suggested changes
Jun 21, 2023
Contributor
LianaHus
left a comment
LianaHus
left a comment
There was a problem hiding this comment.
missing a tooltip on verify btn when it is disabled
Collaborator
Author
|
See, tooltip is there: https://github.com/ethereum/remix-project/blob/master/apps/etherscan/src/app/components/SubmitButton.tsx#L19 but it is not easily visible. May be needs some improvement |
LianaHus
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3813