Skip to content

Conversation

@edisinovcic
Copy link
Collaborator

On each compile save metadata.json file to artifacts.

@yann300
Copy link
Contributor

yann300 commented Sep 8, 2020

This will help fixing #72 .
Basically sourcify won't need to store the metadata in its plugin, but the metadata will be store in remix directly.
FYI we already store an artifact file (JSON) which contain another information (bytecode,...), in this PR we are saving exactly what the compiler outputs.
this also means that now we store 2 files for each compiled contracts.

  • < contractname >.json : contains gas estimation, bytecode, sourcemaps,...
  • < contractname >_metadata.json the actual compiler metada output

@edisinovcic
Copy link
Collaborator Author

If everything is good @ioedeveloper @yann300 feel free to merge.

@yann300
Copy link
Contributor

yann300 commented Sep 8, 2020

@edisinovcic ok, could you just remove the remaining console.log

@edisinovcic edisinovcic force-pushed the feature-metadata-saver branch from a455be3 to 0e5f1ab Compare September 8, 2020 12:32
@edisinovcic
Copy link
Collaborator Author

@yann300 solved.

@yann300 yann300 requested a review from ioedeveloper September 9, 2020 10:16
@yann300 yann300 merged commit 1663f1a into master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants