misc refactors remix-debug / remix-lib #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
reviewed
Oct 1, 2020
| @@ -0,0 +1,57 @@ | |||
| const remixLib = require('@remix-project/remix-lib') | |||
Contributor
There was a problem hiding this comment.
I think this file can be removed (it was already removed in an another PR)
yann300
reviewed
Oct 1, 2020
| @@ -0,0 +1,55 @@ | |||
| 'use strict' | |||
Contributor
There was a problem hiding this comment.
I think this file was also removed from a precedent PR
yann300
reviewed
Oct 1, 2020
| var remixLib = require('@remix-project/remix-lib') | ||
| var yo = require('yo-yo') | ||
| var EventsDecoder = remixLib.execution.EventsDecoder | ||
| var TransactionReceiptResolver = require('../../lib/transactionReceiptResolver') |
Contributor
There was a problem hiding this comment.
transactionReceiptResolver.js the file seems not removed, do you still need it?
yann300
force-pushed
the
refactor_remix_debug5_ab
branch
from
2c54021 to
382d30e
Compare
yann300
reviewed
Oct 8, 2020
| const txFormat = require('./txFormat') | ||
| const txHelper = require('./txHelper') | ||
|
|
||
| function addExecutionCosts(txResult, tx) { |
Contributor
There was a problem hiding this comment.
This function is already defined in this file, not sure which one you want to keep
Contributor
|
fix #431 |
iurimatias
force-pushed
the
refactor_remix_debug5_ab
branch
from
98074a5 to
76d8319
Compare
yann300
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.