Move Remixd To Monorepo #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- start/stop geth/mist to the right ipc endpoint - start a frontend - automine if pending txs
Options to run geth, mist, frontend
add resolveDirectory & change sharedfolder `get` return value
Add "exists" function
Move stdout to dependencies section
Move serve and web3 to dependencies section
fix rename
Aniket-Engg
reviewed
Oct 6, 2020
| @@ -0,0 +1,3 @@ | |||
| import { RemixdClient as sharedfolder } from './services/remixdClient' | |||
Collaborator
There was a problem hiding this comment.
May be you can use export { RemixdClient as sharedfolder } from './services/remixdClient'
Collaborator
Author
There was a problem hiding this comment.
We should keep this. Making a change to this will break remix-desktop.
Aniket-Engg
approved these changes
Oct 15, 2020
|
{ "extends": "../../.eslintrc", "rules": {}, "ignorePatterns": ["!**/*"] } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.