Remove leading zeroes in prerelease components.#1074
Merged
Conversation
| string(STRIP "${SOL_VERSION_PRERELEASE}" SOL_VERSION_PRERELEASE) | ||
| else() | ||
| string(TIMESTAMP SOL_VERSION_PRERELEASE "develop.%Y.%m.%d" UTC) | ||
| string(REPLACE .0 . SOL_VERSION_PRERELEASE "${SOL_VERSION_PRERELEASE}") |
Contributor
There was a problem hiding this comment.
The indent seems to have changed, though I don't know the consequences in cmake files.
Contributor
Author
|
Sorry, I need to merge this now, otherwise browser-solidity will keep on breaking. |
ekpyron
reviewed
Jan 17, 2020
| DATE=$(date --date="$(git log -1 --date=iso --format=%ad HEAD)" --utc +%Y.%-m.%-d) | ||
|
|
||
| # remove leading zeros in components - they are not semver-compatible | ||
| COMMIT=$(echo "$COMMIT" | sed -e 's/^0*//') |
Collaborator
There was a problem hiding this comment.
Was it wrong to add this here or was this part intentional as well? This is basically what introduces #8127
Contributor
Author
There was a problem hiding this comment.
It was intentional. There cannot be leading zeros in this semver component.
axic
pushed a commit
to ipsilon/solidity
that referenced
this pull request
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.