Yul FunctionCallFinder uses FunctionName instead of strings as search key #15840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clonker
force-pushed
the
function_call_finder_on_handle
branch
4 times, most recently
from
1fd9fd4 to
761970b
Compare
cameel
reviewed
Feb 14, 2025
Collaborator
cameel
left a comment
cameel
left a comment
There was a problem hiding this comment.
Looks like this is a bugfix so we should check if the bug had any observable effects and, if so, cover them with regression tests.
Other than that just, some minor style tweaks and simplifications.
clonker
force-pushed
the
function_call_finder_on_handle
branch
2 times, most recently
from
a14754f to
32637d4
Compare
cameel
reviewed
Mar 3, 2025
Collaborator
cameel
left a comment
cameel
left a comment
There was a problem hiding this comment.
Still needs a few tweaks.
clonker
force-pushed
the
function_call_finder_on_handle
branch
from
32637d4 to
9892d23
Compare
cameel
force-pushed
the
function_call_finder_on_handle
branch
from
9892d23 to
b07843d
Compare
cameel
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description is in the title